Skip to content

Commit b4742b7

Browse files
committed
chore(test): remove CI-SKIP from devtools tests
1 parent 394b7a6 commit b4742b7

File tree

1 file changed

+6
-16
lines changed

1 file changed

+6
-16
lines changed

tests/devtools.test.tsx

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -678,7 +678,7 @@ it('preserves isRecording after setting from devtools', async () => {
678678
/* features:
679679
* [] if name is undefined - use multiple devtools connections.
680680
* [] if name and store is defined - use connection for specific 'name'.
681-
* [] if two stores are coonected to one 'name' group and.
681+
* [] if two stores are connected to one 'name' group and.
682682
* another connected to another 'name' group, then feature should work
683683
* [] check actions with this feature, for multiple stores that store prefixes are added -
684684
* [] - reset
@@ -720,9 +720,7 @@ describe('when redux connection was called on multiple stores with `name` undefi
720720
})
721721

722722
describe('when `store` property was provided in `devtools` call in options', () => {
723-
// FIXME: Run this test separately in CI, until we're able to test modules in isolation i.e. use jest.resetModule and re-import modules in each test
724-
// Relevant issues https://github.com/nodejs/node/issues/35889
725-
it('[CI-MATRIX-1] should create single connection for all indernal calls of .connect and `store` is not passed to .connect', async () => {
723+
it('should create single connection for all internal calls of .connect and `store` is not passed to .connect', async () => {
726724
const { devtools: newDevtools } = await import('zustand/middleware')
727725

728726
const options1 = { store: 'store1123', foo: 'bar1' }
@@ -743,9 +741,7 @@ describe('when redux connection was called on multiple stores with `name` undefi
743741
})
744742
})
745743

746-
// FIXME: Run this test separately in CI, until we're able to test modules in isolation i.e. use jest.resetModule and re-import modules in each test
747-
// Relevant issues https://github.com/nodejs/node/issues/35889
748-
it('[CI-MATRIX-2] should call `.init` on single connection with combined states after each `create(devtools` call', async () => {
744+
it('should call `.init` on single connection with combined states after each `create(devtools` call', async () => {
749745
const { devtools: newDevtools } = await import('zustand/middleware')
750746

751747
const options1 = { store: 'store12' }
@@ -839,9 +835,7 @@ describe('when redux connection was called on multiple stores with `name` provid
839835
})
840836
})
841837

842-
// FIXME: Run this test separately in CI, until we're able to test modules in isolation i.e. use jest.resetModule and re-import modules in each test
843-
// Relevant issues https://github.com/nodejs/node/issues/35889
844-
it('[CI-MATRIX-3] should call `.init` on single connection with combined states after each `create(devtools` call', async () => {
838+
it('should call `.init` on single connection with combined states after each `create(devtools` call', async () => {
845839
const { devtools: newDevtools } = await import('zustand/middleware')
846840
const connectionNameGroup1 = 'test1'
847841
const connectionNameGroup2 = 'test2'
@@ -2352,9 +2346,7 @@ describe('when create devtools was called multiple times with `name` and `store`
23522346
console.error = originalConsoleError
23532347
})
23542348

2355-
// FIXME: Run this test separately in CI, until we're able to test modules in isolation i.e. use jest.resetModule and re-import modules in each test
2356-
// Relevant issues https://github.com/nodejs/node/issues/35889
2357-
it('[CI-MATRIX-4] does nothing even if there is `api.dispatch`, connections isolated from each other', async () => {
2349+
it('does nothing even if there is `api.dispatch`, connections isolated from each other', async () => {
23582350
const { devtools: newDevtools } = await import('zustand/middleware')
23592351

23602352
const name1 = 'name1'
@@ -2402,9 +2394,7 @@ describe('when create devtools was called multiple times with `name` and `store`
24022394
expect((api2 as any).dispatch).not.toBeCalled()
24032395
})
24042396

2405-
// FIXME: Run this test separately in CI, until we're able to test modules in isolation i.e. use jest.resetModule and re-import modules in each test
2406-
// Relevant issues https://github.com/nodejs/node/issues/35889
2407-
it('[CI-MATRIX-5] dispatches with `api.dispatch` when `api.dispatchFromDevtools` is set to true, connections are isolated from each other', async () => {
2397+
it('dispatches with `api.dispatch` when `api.dispatchFromDevtools` is set to true, connections are isolated from each other', async () => {
24082398
const { devtools: newDevtools } = await import('zustand/middleware')
24092399
const name1 = 'name1'
24102400
const name2 = 'name2'

0 commit comments

Comments
 (0)