fix(store): derived atom not updating when its value changes if another atom is read it conditionally #2700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/DKE6DFJX8 |
See documentations for usage instructions.
Member
dai-shi
reviewed
Aug 12, 2024
src/vanilla/store.ts
Outdated
Comment on lines
512
to
514
| const prevEpochNumbers: number[] = topsortedAtoms.map( | ||
| (a) => getAtomState(a).n, | ||
| ) |
Member
There was a problem hiding this comment.
Looks good. Let me add a commit to refactor something.
dai-shi
approved these changes
Aug 12, 2024
Member
dai-shi
left a comment
dai-shi
left a comment
There was a problem hiding this comment.
This should be a good fix. Let's ship it.
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
Fixes #2697
Summary
Seems a regression in store2 introduced in v2.9.0.
Check List
pnpm run prettierfor formatting code and docs