Skip to content

Commit a26203e

Browse files
authored
chore: enable isolatedDeclarations (#2687)
* experimental: enable isolatedDeclarations * update typescript
1 parent ab68d4d commit a26203e

File tree

6 files changed

+55
-50
lines changed

6 files changed

+55
-50
lines changed

.github/workflows/test-old-typescript.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@ jobs:
4141
cache-dependency-path: '**/pnpm-lock.yaml'
4242
- run: pnpm install --frozen-lockfile
4343
- run: pnpm build
44+
- name: Patch for all TS
45+
run: |
46+
sed -i~ 's/"isolatedDeclarations": true,//' tsconfig.json
4447
- name: Patch for v4/v3 TS
4548
if: ${{ startsWith(matrix.typescript, '4.') || startsWith(matrix.typescript, '3.') }}
4649
run: |

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@
169169
"ts-expect": "^1.3.0",
170170
"ts-node": "^10.9.2",
171171
"tslib": "^2.6.3",
172-
"typescript": "^5.5.4",
172+
"typescript": "^5.6.2",
173173
"vitest": "^2.0.5",
174174
"wonka": "^6.3.4"
175175
},

pnpm-lock.yaml

Lines changed: 47 additions & 47 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/babel/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export function isAtom(
88
t: typeof types,
99
callee: babel.types.Expression | babel.types.V8IntrinsicIdentifier,
1010
customAtomNames: PluginOptions['customAtomNames'] = [],
11-
) {
11+
): boolean {
1212
const atomNames = [...atomFunctionNames, ...customAtomNames]
1313
if (t.isIdentifier(callee) && atomNames.includes(callee.name)) {
1414
return true

src/vanilla/utils/constants.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
export const RESET = Symbol(
1+
export const RESET: unique symbol = Symbol(
22
import.meta.env?.MODE !== 'production' ? 'RESET' : '',
33
)

tsconfig.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
"noUncheckedIndexedAccess": true,
1212
"exactOptionalPropertyTypes": true,
1313
"verbatimModuleSyntax": true,
14+
"declaration": true,
15+
"isolatedDeclarations": true,
1416
"noEmit": true,
1517
"baseUrl": ".",
1618
"paths": {

0 commit comments

Comments
 (0)