Skip to content

fix(types): fix usage of ambient THREE namespace#2517

Merged
abernier merged 2 commits into
pmndrs:masterfrom
Methuselah96:fix-center-three-reference
Sep 11, 2025
Merged

fix(types): fix usage of ambient THREE namespace#2517
abernier merged 2 commits into
pmndrs:masterfrom
Methuselah96:fix-center-three-reference

Conversation

@Methuselah96

@Methuselah96 Methuselah96 commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

Why

A usage of the ambient THREE namespace snuck back in with #2511. The ambient THREE namespace was removed in @types/three@0.162.0.

What

Removes usages of the ambient THREE namespace.

Checklist

  • Ready to be merged

@vercel

vercel Bot commented Aug 18, 2025

Copy link
Copy Markdown

@Methuselah96 is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci

codesandbox-ci Bot commented Aug 18, 2025

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Methuselah96

Copy link
Copy Markdown
Contributor Author

@abernier Friendly bump, should be an easy merge

@abernier

abernier commented Sep 11, 2025

Copy link
Copy Markdown
Member

@Methuselah96 why just Center? Shouldn't this apply more largely to all other drei's comps?

@abernier abernier merged commit 3b5d7dc into pmndrs:master Sep 11, 2025
3 of 4 checks passed
@Methuselah96

Methuselah96 commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

In other components, there is a import * as THREE from 'three', but not in Center. An alternative fix would be to import THREE, but it seems like the convention in Center is to use named imports

@Methuselah96 Methuselah96 deleted the fix-center-three-reference branch September 11, 2025 16:35
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 10.7.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

creativoma pushed a commit to creativoma/drei that referenced this pull request Jan 18, 2026
Co-authored-by: Gianmarco <gianmarcosimone89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants