Skip to content

Commit 75f0dad

Browse files
committed
fix(bar): don't crash with valueScale.type === 'log'
1 parent 312b64d commit 75f0dad

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

packages/bar/src/compute/stacked.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ type Params<RawDatum, XScaleInput, YScaleInput> = {
1818
const flattenDeep = <T>(arr: T[]): T =>
1919
arr.some(Array.isArray) ? flattenDeep(([] as T[]).concat(...arr)) : ((arr as unknown) as T)
2020

21+
const filterZerosIfLog = (array: number[], type: string) =>
22+
type === 'log' ? array.filter(num => num !== 0) : array
23+
2124
/**
2225
* Generates x/y scales & bars for vertical stacked bar chart.
2326
*/
@@ -178,7 +181,10 @@ export const generateStackedBars = <RawDatum extends BarDatum>({
178181
...valueScale,
179182
}
180183

181-
const values = flattenDeep((stackedData as unknown) as number[][])
184+
const values = filterZerosIfLog(
185+
flattenDeep((stackedData as unknown) as number[][]),
186+
valueScale.type
187+
)
182188
const min = Math.min(...values)
183189
const max = Math.max(...values)
184190

0 commit comments

Comments
 (0)