Skip to content

Conversation

@MrTango
Copy link
Contributor

@MrTango MrTango commented Feb 11, 2025

First-time contributors

You must read and follow our First-time contributors.


Submit a pull request

Thank you for your contribution to the Plone Documentation.

Before submitting this pull request, please make sure you follow our guides:

Issue number

  • Fixes #

Description

Write a description of the fixes or improvements.

Add screenshots or links to a preview of the changes


📚 Documentation preview 📚: https://plone6--1850.org.readthedocs.build/backend/deprecation.html

MrTango and others added 3 commits February 12, 2025 11:39
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the amended original plan #1464 (comment)


: They may got renamed for consistency or are superfluos after an update.
Code does not need to break to support this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything up to this point is a Conceptual Guide, and needs to be split into a separate file placed in the conceptual-guides directory.

Everything after this point is a How-to Guide and should be moved under Developer guide. This section is a recent addition, and more suitable for this content.

Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall fine, found two minor improvements.

configuration-registry
content-types/index
control-panels
deprecation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you all think that this insertion point in the TOC is the most appropiate place for this subject?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not. See #1850 (review).

@jensens jensens self-requested a review February 17, 2025 12:07
jensens
jensens previously approved these changes Feb 17, 2025
ale-rt
ale-rt previously approved these changes Feb 20, 2025
@stevepiercy
Copy link
Contributor

@MrTango I'm awaiting changes per #1850 (review) before merging. Please let me know. Thank you!

@stevepiercy
Copy link
Contributor

@MrTango should I close this PR as abandoned and won't fix? It needs help before it can be merged.

@ale-rt
Copy link
Member

ale-rt commented Dec 4, 2025

@MrTango should I close this PR as abandoned and won't fix? It needs help before it can be merged.

It would be a pity because it is a very nice write up :/

@stevepiercy
Copy link
Contributor

It would be a pity because it is a very nice write up :/

Indeed. However, my review has not been addressed. I don't know why. No response from @MrTango implies this PR is not needed. If you care to push it forward, please be my guest.

@jensens
Copy link
Member

jensens commented Dec 4, 2025

@MrTango should I close this PR as abandoned and won't fix? It needs help before it can be merged.

I will take a look. I wrote this initially back in the days... so I would like to see it survive.

@jensens jensens dismissed stale reviews from ale-rt and themself via 2ccbcf2 December 4, 2025 23:45
@jensens jensens force-pushed the chapter-deprecation branch from 2ccbcf2 to 46b14eb Compare December 4, 2025 23:58
@jensens
Copy link
Member

jensens commented Dec 5, 2025

Ok, this should work. @stevepiercy what do you think?

Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much to all of you :)
@stevepiercy do you mind having another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: in progress
Status: In Progress

Development

Successfully merging this pull request may close these issues.

6 participants