Skip to content

Commit 8c5ce17

Browse files
committed
fix(flexbox): Fix Flexbox not applying translate transforms to non-text/image elements
1 parent 1c9a5ac commit 8c5ce17

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

.changeset/honest-facts-help.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@plextv/react-lightning-plugin-flexbox": patch
3+
---
4+
5+
fix(flexbox): Fix Flexbox not applying translate transforms to non-text/image elements

packages/plugin-flexbox/src/LightningManager.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class LightningManager {
4040
this._yogaManager.addNode(element.id);
4141

4242
const disposers = [
43-
element.on('destroy', async () => {
43+
element.on('destroy', () => {
4444
for (const dispose of disposers) {
4545
dispose();
4646
}
@@ -52,13 +52,13 @@ export class LightningManager {
5252
this._yogaManager!.removeNode(element.id);
5353
}),
5454

55-
element.on('childAdded', async (child, index) => {
55+
element.on('childAdded', (child, index) => {
5656
// biome-ignore lint/style/noNonNullAssertion: Guaranteed to exist. See above
5757
this._yogaManager!.addChildNode(element.id, child.id, index);
5858
this.applyStyle(element.id, element.style);
5959
}),
6060

61-
element.on('childRemoved', async (child) => {
61+
element.on('childRemoved', (child) => {
6262
// This will remove any pending worker style updates that haven't been sent
6363

6464
// biome-ignore lint/style/noNonNullAssertion: Guaranteed to exist. See above
@@ -67,13 +67,19 @@ export class LightningManager {
6767
this._yogaManager!.removeNode(child.id);
6868
}),
6969

70-
element.on('stylesChanged', async () => {
70+
element.on('inViewport', () => {
71+
if (!element.isTextElement && !element.isImageElement) {
72+
this.applyStyle(element.id, element.props.style);
73+
}
74+
}),
75+
76+
element.on('stylesChanged', () => {
7177
this.applyStyle(element.id, element.props.style);
7278
}),
7379

7480
element.on(
7581
'textureLoaded',
76-
async (
82+
(
7783
node:
7884
| RendererNode<LightningElement>
7985
| TextRendererNode<LightningTextElement>,

0 commit comments

Comments
 (0)