Skip to content

toArray type overloading #7808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

toArray type overloading #7808

merged 1 commit into from
Jun 30, 2025
+80 −0

Conversation

@kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Jun 30, 2025

  • Adds overloads for toArray method typing to correctly return number[] or ArrayBufferView depending on the type of the output array arr

@kpal81xd kpal81xd self-assigned this Jun 30, 2025
@kpal81xd kpal81xd added bug Something isn't working and removed bug Something isn't working labels Jun 30, 2025
@kpal81xd kpal81xd requested a review from a team June 30, 2025 16:46
@kpal81xd kpal81xd merged commit 5003655 into main Jun 30, 2025
7 checks passed
@kpal81xd kpal81xd deleted the toarray-overload branch June 30, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kpal81xd @willeastcott