Support gsplat worker on nodejs #7770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the existing GSplat sorting worker to run both in browsers and under Node.js without changing its core logic.
- Detects environment (browser vs Node) inside the worker and in the main thread
- Replaces
self/onmessagewith a unifiedmyselfand branches event registration - Instantiates
Workerdifferently in Node (witheval: true) vs browser (viaBlob)
Comments suppressed due to low confidence (1)
src/scene/gsplat/gsplat-sorter.js:330
- In Node.js context,
Workeris not a global. You need to import or require{ Worker }from'worker_threads'before instantiating the worker.
this.worker = new Worker(workerSource, {
willeastcott
approved these changes
Jun 14, 2025
mvaligursky
pushed a commit
that referenced
this pull request
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes small changes to the gsplat sort worker so it can run under nodejs.
Functionality remains unchanged.