Use arrow functions in all example code #7615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the code examples in JSDoc blocks by replacing traditional function expressions with arrow functions.
- Updated examples in multiple modules (scene, xr, asset, etc.) to use arrow functions for callbacks.
- Enhanced code readability and consistency across documented examples.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/scene/graph-node.js | Converted callback functions in example blocks. |
| src/framework/xr/xr-input-source.js | Replaced anonymous functions with arrow functions. |
| src/framework/xr/xr-hit-test.js | Modernized hit test examples with arrow functions. |
| src/framework/xr/xr-hit-test-source.js | Updated callback syntax in examples. |
| src/framework/xr/xr-anchors.js | Converted callbacks in anchor management examples. |
| src/framework/script.js | Modernized loading screen example with arrow functions. |
| src/framework/scene-registry.js | Updated scene loading and settings examples. |
| src/framework/handlers/container.js | Revised container resource examples to use arrow functions. |
| src/framework/components/camera/component.js | Converted camera component example callbacks. |
| src/framework/bundle/bundle.js | Updated bundle event examples with arrow functions. |
| src/framework/asset/asset.js | Replaced asset ready callback with arrow function. |
| src/framework/asset/asset-registry.js | Modernized asset registry examples with arrow functions. |
willeastcott
added a commit
that referenced
this pull request
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize the code in
@exampleblocks by using arrow functions.I confirm I have read the contributing guidelines and signed the Contributor License Agreement.