[FIX] Restore callback descriptions #7607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request restores callback API reference descriptions and updates callback declarations throughout the codebase. It also removes legacy callbacks and explicitly sets return types to void to avoid defaulting to any.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/scene/mesh-instance.js | Updated callback documentation for CalculateSortDistanceCallback |
| src/scene/graph-node.js | Updated callback documentation for find/forEach node callbacks |
| src/platform/net/http.js | Reformatted HttpResponseCallback with explicit return type |
| src/platform/input/mouse.js | Updated LockMouseCallback documentation with explicit void return |
| src/framework/xr/xr-manager.js | Revised XR callback documentation and updated references |
| src/framework/xr/xr-hit-test.js | Adjusted callback documentation for XR hit test callbacks |
| src/framework/xr/xr-anchors.js | Updated XR anchor callback documentation |
| src/framework/xr/xr-anchor.js | Revised XR anchor persist and forget callbacks |
| src/framework/script.js | Removed legacy CreateScriptCallback and updated createLoadingScreen callback |
| src/framework/scene-registry.js | Updated several scene registry callback documentations with explicit void return |
| src/framework/handlers/model.js | Updated AddParserCallback documentation |
| src/framework/handlers/loader.js | Updated ResourceLoaderCallback documentation; fixed a spelling error in a comment |
| src/framework/handlers/handler.js | Revised ResourceHandlerCallback documentation with explicit void return |
| src/framework/components/camera/component.js | Updated camera callbacks documentation with explicit void return |
| src/framework/asset/asset.js | Updated AssetReadyCallback documentation |
| src/framework/asset/asset-registry.js | Updated asset registry callbacks with explicit void return and clarified types |
| src/framework/app-base.js | Updated several AppBase callback documentations with explicit void return |
| src/framework/anim/evaluator/anim-target.js | Updated parameter type for the animation setter callback |
| src/core/wasm-module.js | Revised WasmModule callbacks documentation |
| src/core/event-handler.js | Updated HandleEventCallback documentation with explicit void return |
mvaligursky
approved these changes
Apr 25, 2025
willeastcott
added a commit
that referenced
this pull request
Apr 25, 2025
* [FIX] Restore callback descriptions * Revert package-lock.json * Grammar tweak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnimSetter(internal) andCreateScriptCallback(should have been removed with legacy scripts code).voidwhere applicable (otherwiseanyis assumed).Fixes #7604
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.