Skip to content

[Fix] Fix shader passes order #7598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

[Fix] Fix shader passes order #7598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/scene/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,12 +771,12 @@ export const SHADER_FORWARD = 0;

export const SHADER_PREPASS = 1;

// shadow pass used by the shadow rendering code
export const SHADER_SHADOW = 2;

// shader pass used by the Picker class to render mesh ID
export const SHADER_PICK = 3;

// shadow pass used by the shadow rendering code
export const SHADER_SHADOW = 4;

/**
* Shader that performs forward rendering.
*
Expand Down
2 changes: 1 addition & 1 deletion src/scene/shader-pass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ class ShaderPass {
// add default passes in the required order, to match the constants
add('forward', SHADER_FORWARD, { isForward: true });
add('prepass', SHADER_PREPASS);
add('pick', SHADER_PICK);
add('shadow', SHADER_SHADOW);
add('pick', SHADER_PICK);
}

/**
Expand Down