Skip to content

[BREAKING] Removing non-functional depth pass #7597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

[BREAKING] Removing non-functional depth pass #7597

merged 1 commit into from
Apr 24, 2025

Conversation

@mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 24, 2025 •
edited
Loading

  • marking this as breaking, but as this was non-functional for a very long time (even in engine v1), this change likely won't affect anybody.
  • Editor was using this, but this non-functional behaviour was replaced by using RenderPassPrepass, and this can be safely removed from the engine

@mvaligursky mvaligursky merged commit 3958660 into main Apr 24, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-remove-depth-pass branch April 24, 2025 12:06
@mvaligursky mvaligursky mentioned this pull request Apr 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvaligursky @willeastcott