Gsplat rotation fix #7587
Merged
Gsplat rotation fix #7587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
added
bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a subtle rotation bug in the gsplat rendering by clamping the sqrt argument to ensure a non-negative value.
- Updated the unpackRotation function to use sqrt(max(0.0, 1.0 - dot(packed, packed))), which prevents potential negative values under the square root.
willeastcott
approved these changes
Apr 23, 2025
slimbuck
added a commit
that referenced
this pull request
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes playcanvas/supersplat#485
We recently moved covariance vector calculation from cpu to gpu (in #7380) in order to gain precision during render.
This change included a subtle rotation bug which is fixed in this PR.