Update test/integration/vitesscluster/vitesscluster_test.go

jdoupe · mattlord · web-flow · commit a0d18169c94b · 2025-11-15T09:39:20.000-06:00
Co-authored-by: Matt Lord &lt;mattalord@gmail.com&gt;
diff --git a/test/integration/vitesscluster/vitesscluster_test.go b/test/integration/vitesscluster/vitesscluster_test.go
@@ -200,12 +200,8 @@ func TestVtbackupExtraFlagsPropagated(t *testing.T) {
 		}
 	}
 	joined := strings.Join(args, " ")
-	if !strings.Contains(joined, "--foo=bar") {
-		f.Fatalf("vtbackup args missing --foo=bar: %v", args)
-	}
-	if !strings.Contains(joined, "--baz=qux") {
-		f.Fatalf("vtbackup args missing --baz=qux: %v", args)
-	}
+	require.Contains(t, joined, "--foo=bar", "vtbackup args missing --foo=bar: %v", args)
+	require.Contains(t, joined, "--baz=qux", "vtbackup args missing --baz=qux: %v", args)
 }
 
 func verifyBasicVitessCluster(f *framework.Fixture, ns, cluster string) {

Original file line number	Diff line number	Diff line change
`@@ -200,12 +200,8 @@ func TestVtbackupExtraFlagsPropagated(t *testing.T) {`
`200`	`200`	`}`
`201`	`201`	`}`
`202`	`202`	`joined := strings.Join(args, " ")`
`203`		`- if !strings.Contains(joined, "--foo=bar") {`
`204`		`- f.Fatalf("vtbackup args missing --foo=bar: %v", args)`
`205`		`- }`
`206`		`- if !strings.Contains(joined, "--baz=qux") {`
`207`		`- f.Fatalf("vtbackup args missing --baz=qux: %v", args)`
`208`		`- }`
	`203`	`+ require.Contains(t, joined, "--foo=bar", "vtbackup args missing --foo=bar: %v", args)`
	`204`	`+ require.Contains(t, joined, "--baz=qux", "vtbackup args missing --baz=qux: %v", args)`
`209`	`205`	`}`
`210`	`206`
`211`	`207`	`func verifyBasicVitessCluster(f *framework.Fixture, ns, cluster string) {`