Skip to content

Conversation

@mxcl
Copy link
Member

@mxcl mxcl commented Jan 2, 2024

Refs #211

@mxcl mxcl force-pushed the python-venv-poetry branch from 99e8087 to fd2f8ce Compare January 4, 2024 05:58
@mxcl mxcl force-pushed the python-venv-poetry branch from 342f604 to 80d08dc Compare January 4, 2024 06:31
@mxcl
Copy link
Member Author

mxcl commented Jan 4, 2024

A significant difference to the previous way we stubbed is that Python is no longer a direct dependency of the package, but is instead loaded inside the shim.

This means that packages can use entirely different python versions to those that may be set in the user’s environments. Which specifically works around conflicts like: user wants python 3.12 and poetry, a tool they are using locally, requires 3.11.

However, this means any package that moves to this shim needs RESTOCKING, since the dep has been removed from the yaml.

This is one of the reasons I am considering moving to a system where each package records its deps alongside the package at build time.

@mxcl mxcl merged commit 3bd9b17 into main Jan 4, 2024
@mxcl mxcl deleted the python-venv-poetry branch January 4, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants