Job Concurrency: Fix issue where jobs stuck in "starting" state could cause queue limits to be bypassed.

Author: jhuckaby

lib/job.js

@@ -688,10 +688,13 @@ class Jobs {
 		var job_limit = Tools.findObject( job.limits, { type: 'job', enabled: true } );
 
 		if (job_limit && job_limit.amount) {
-			var jobs = this.findSimilarJobs(job, { state: 'active' });
+			// include jobs in "starting" state so concurrent start actions can't bypass limits
+			var jobs = this.findSimilarJobs(job, { state: 'active' }).concat(
+				this.findSimilarJobs(job, { state: 'starting' })
+			);
 
 			if (jobs.length >= job_limit.amount) {
-				// job limit reached -- can we queue?
+				// concurrent job limit reached -- can we queue?
 				var queue_limit = Tools.findObject( job.limits, { type: 'queue', enabled: true } );
 
 				if (queue_limit && queue_limit.amount) {