Remove "password" text field variant type, as it gives a false sense of data security (use a secret vault instead).

Author: jhuckaby

htdocs/js/pages/Base.class.js

@@ -2495,14 +2495,8 @@ Page.Base = class Base extends Page {
 							var variant_def = find_object( config.ui.text_field_variants, { id: param.variant } );
 							if (variant_def) elem_icon = variant_def.icon;
 						}
-						if (param.variant == 'password') {
-							html += '<i class="mdi mdi-' + elem_icon + '">&nbsp;</i>';
-							html += '<span class="data_value">********</span>';
-						}
-						else {
-							html += '<i class="link mdi mdi-' + elem_icon + '" onClick="$P().copyPluginParamValue(this)" title="Copy to Clipboard">&nbsp;</i>';
-							html += '<span class="data_value">' + encode_entities(elem_value) + '</span>';
-						}
+						html += '<i class="link mdi mdi-' + elem_icon + '" onClick="$P().copyPluginParamValue(this)" title="Copy to Clipboard">&nbsp;</i>';
+						html += '<span class="data_value">' + encode_entities(elem_value) + '</span>';
 					}
 					else html += none;
 				break;

htdocs/js/pages/PageUtils.class.js

@@ -4164,8 +4164,10 @@ Page.PageUtils = class PageUtils extends Page.Base {
 				case 'text':
 					if (param.variant && (param.variant !== 'text')) {
 						var variant = find_object( config.ui.text_field_variants, { id: param.variant } );
-						nice_type = variant.title;
-						nice_icon = variant.icon;
+						if (variant) {
+							nice_type = variant.title;
+							nice_icon = variant.icon;
+						}
 					}
 					if (param.value.toString().length) pairs.push([ 'Default', '“' + strip_html(param.value) + '”' ]);
 					else pairs.push([ "(No default)" ]);

internal/ui.json

@@ -1048,7 +1048,6 @@
 		{ "id": "datetime-local", "title": "Date / Time", "icon": "calendar-clock" },
 		{ "id": "email", "title": "Email Address", "icon": "email-edit-outline" },
 		{ "id": "number", "title": "Number", "icon": "counter" },
-		{ "id": "password", "title": "Password", "icon": "form-textbox-lock" },
 		{ "id": "text", "title": "Plain Text", "icon": "form-textbox" },
 		{ "id": "time", "title": "Time", "icon": "clock-edit-outline" },
 		{ "id": "tel", "title": "Phone Number", "icon": "phone-dial" },