Skip to content

Commit 239494d

Browse files
committed
Bug Fix: Server group assignments were not correctly being passed to xySat when autoGroup was set.
1 parent 4b481af commit 239494d

2 files changed

Lines changed: 14 additions & 12 deletions

File tree

lib/comm.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -196,22 +196,22 @@ class Communication {
196196
delete socket.server.nonce; // no longer needed
197197

198198
// join the network
199-
this.addServer(socket.server);
199+
this.addServer(socket.server, function() {
200+
// make sure server has vital data
201+
socket.send('joined', {
202+
config: Tools.mergeHashes( { airgap: self.config.get('airgap') }, self.config.getPath('satellite.config') ),
203+
masterData: self.masterData,
204+
groups: socket.server.groups, // in case it was auto-assigned by hostname
205+
plugins: Tools.findObjects( self.plugins, { type: 'event' } ),
206+
commands: self.getCommandsWithSecrets(),
207+
numServers: Tools.numKeys(self.servers)
208+
});
209+
});
200210

201211
// socket is auth'ed
202212
this.logComm(6, "Server socket has authenticated successfully: " + socket.id);
203213
socket.auth = true;
204214
socket.type = 'server';
205-
206-
// make sure server has vital data
207-
socket.send('joined', {
208-
config: Tools.mergeHashes( { airgap: this.config.get('airgap') }, this.config.getPath('satellite.config') ),
209-
masterData: this.masterData,
210-
groups: socket.server.groups, // in case it was auto-assigned by hostname
211-
plugins: Tools.findObjects( this.plugins, { type: 'event' } ),
212-
commands: this.getCommandsWithSecrets(),
213-
numServers: Tools.numKeys(this.servers)
214-
});
215215
break;
216216

217217
case 'authenticate':

lib/server.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class ServerManager {
3737
return true;
3838
}
3939

40-
addServer(server) {
40+
addServer(server, callback) {
4141
// add server to network, or update for reconnect
4242
var self = this;
4343

@@ -135,6 +135,8 @@ class ServerManager {
135135
}
136136
self.emit('serverAdded', server);
137137
}); // unbase.insert
138+
139+
callback();
138140
}); // unbase.get
139141
}
140142

0 commit comments

Comments
 (0)