chore: smaller improvements and cleanup (#808)

Author: metcoder95

.github/workflows/nodejs.yml

@@ -38,7 +38,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        node-version: [20.x, 22.x, 23.x]
+        node-version: [20.x, 22.x, 24.x]
     runs-on: ${{matrix.os}}
     steps:
       - uses: actions/checkout@v4

src/histogram.ts

@@ -51,10 +51,6 @@ export class PiscinaHistogramHandler {
     return this.#runTime.count;
   }
 
-  get waitTimeCount(): number {
-    return this.#waitTime.count;
-  }
-
   recordRunTime(value: number) {
     this.#runTime.record(PiscinaHistogramHandler.toHistogramIntegerNano(value));
   }

src/worker.ts

@@ -23,6 +23,7 @@ import {
 commonState.isWorkerThread = true;
 commonState.workerData = workerData;
 
+/* c8 ignore next*/
 function noop (): void {}
 
 const handlerCache : Map<string, Function> = new Map();
@@ -70,6 +71,7 @@ async function getHandler (filename : string, name : string) : Promise<Function
 
   // Limit the handler cache size. This should not usually be an issue and is
   // only provided for pathological cases.
+  /* c8 ignore next */
   if (handlerCache.size > 1000) {
     const [[key]] = handlerCache;
     handlerCache.delete(key);
@@ -132,6 +134,7 @@ function atomicsWaitLoop (port : MessagePort, sharedBuffer : Int32Array) {
     const { async, value } = Atomics.waitAsync(sharedBuffer, kRequestCountField, lastSeenRequestCount);
 
     // We do not check for result
+    /* c8 ignore start */
     return async === true && value.then(() => {
       lastSeenRequestCount = Atomics.load(sharedBuffer, kRequestCountField);
 
@@ -142,6 +145,7 @@ function atomicsWaitLoop (port : MessagePort, sharedBuffer : Int32Array) {
         onMessage(port, sharedBuffer, entry.message);
       }
     });
+    /* c8 ignore stop */
   }
 
   while (currentTasks === 0) {
@@ -231,5 +235,5 @@ async function onMessage (
 }
 
 function throwInNextTick (error : Error) {
-  process.nextTick((e: Error) => { throw e; }, error);
+  queueMicrotask(() => { throw error; });
 }

test/histogram.test.ts

@@ -35,6 +35,49 @@ test('pool will maintain run and wait time histograms by default', async (t: Tes
   t.assert.strictEqual(typeof histogram.resetWaitTime, 'function');
 });
 
+test('pool will maintain reset histograms upon call', async (t: TestContext) => {
+  const pool = new Piscina({
+    filename: resolve(__dirname, 'fixtures/eval.js')
+  });
+
+  const tasks = [];
+  for (let n = 0; n < 10; n++) {
+    tasks.push(pool.run('42'));
+  }
+  await Promise.all(tasks);
+
+  const histogram = pool.histogram;
+  let waitTime = histogram.waitTime;
+  t.assert.ok(waitTime);
+  t.assert.strictEqual(typeof waitTime.average, 'number');
+  t.assert.strictEqual(typeof waitTime.mean, 'number');
+  t.assert.strictEqual(typeof waitTime.stddev, 'number');
+  t.assert.ok(waitTime.min > 0);
+  t.assert.ok(waitTime.max > 0);
+
+  let runTime = histogram.runTime;
+  t.assert.ok(runTime);
+  t.assert.strictEqual(typeof runTime.average, 'number');
+  t.assert.strictEqual(typeof runTime.mean, 'number');
+  t.assert.strictEqual(typeof runTime.stddev, 'number');
+  t.assert.ok(runTime.min > 0);
+  t.assert.ok(runTime.max > 0);
+
+  histogram.resetRunTime();
+  runTime = histogram.runTime;
+  t.assert.ok(Number.isNaN(runTime.average));
+  t.assert.ok(Number.isNaN(runTime.mean));
+  t.assert.ok(Number.isNaN(runTime.stddev));
+  t.assert.strictEqual(runTime.max, 0);
+  
+  histogram.resetWaitTime();
+  waitTime = histogram.waitTime;
+  t.assert.ok(Number.isNaN(waitTime.average));
+  t.assert.ok(Number.isNaN(waitTime.mean));
+  t.assert.ok(Number.isNaN(waitTime.stddev));
+  t.assert.strictEqual(waitTime.max, 0);
+});
+
 test('pool will maintain run and wait time histograms when recordTiming is true', async (t: TestContext) => {
   const pool = new Piscina({
     filename: resolve(__dirname, 'fixtures/eval.js'),