Skip to content

Conversation

@dantownsend
Copy link
Member

Resolves #396

@dantownsend dantownsend added the enhancement New feature or request label Jun 11, 2024
@dantownsend dantownsend requested a review from sinisaos June 11, 2024 17:47
@dantownsend
Copy link
Member Author

I just thought, we should probably change the styles of the button when it's disabled, or show a spinner or something.

Copy link
Member

@sinisaos sinisaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow reply. I tried your changes on a slow network and everything works. The button is disabled until the API responds. The disabled button is a different color, but if you want you can increase the contrast even more with something like this

button:disabled {
    background-color: #9fc8eb; /* or some other shade of color */
}

@dantownsend
Copy link
Member Author

dantownsend commented Jun 12, 2024

@sinisaos Thanks. I did what you suggested - tried a few different colours, but in the end I reduced the opacity of the button a bit when disabled. It's a tricky one - if the contrast is too great, it can be jarring if the network request is fast.

@dantownsend dantownsend merged commit cafbdec into master Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Disabling the save button after click?

3 participants