[BCB] Remove legacy config options with _ in their name

Author: ondrejmirtes

extension.neon

@@ -5,11 +5,8 @@ parameters:
 		uncheckedExceptionClasses:
 			- 'Symfony\Component\Console\Exception\InvalidArgumentException'
 	symfony:
-		container_xml_path: null
 		containerXmlPath: null
-		constant_hassers: true
 		constantHassers: true
-		console_application_loader: null
 		consoleApplicationLoader: null
 	featureToggles:
 		skipCheckGenericClasses:
@@ -109,11 +106,8 @@ parameters:
 
 parametersSchema:
 	symfony: structure([
-		container_xml_path: schema(string(), nullable())
 		containerXmlPath: schema(string(), nullable())
-		constant_hassers: bool()
 		constantHassers: bool()
-		console_application_loader: schema(string(), nullable())
 		consoleApplicationLoader: schema(string(), nullable())
 	])
 

src/Symfony/Configuration.php

@@ -18,17 +18,17 @@ public function __construct(array $parameters)
 
 	public function getContainerXmlPath(): ?string
 	{
-		return $this->parameters['containerXmlPath'] ?? $this->parameters['container_xml_path'] ?? null;
+		return $this->parameters['containerXmlPath'];
 	}
 
 	public function hasConstantHassers(): bool
 	{
-		return $this->parameters['constantHassers'] ?? $this->parameters['constant_hassers'] ?? true;
+		return $this->parameters['constantHassers'];
 	}
 
 	public function getConsoleApplicationLoader(): ?string
 	{
-		return $this->parameters['consoleApplicationLoader'] ?? $this->parameters['console_application_loader'] ?? null;
+		return $this->parameters['consoleApplicationLoader'];
 	}
 
 }

tests/Symfony/config.neon

@@ -1,4 +1,4 @@
 parameters:
 	symfony:
-		console_application_loader: console_application_loader.php
-		container_xml_path: container.xml
+		consoleApplicationLoader: console_application_loader.php
+		containerXmlPath: container.xml