added tests for Violations class #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #283 +/- ##
============================================
+ Coverage 93.73% 94.23% +0.49%
Complexity 376 376
============================================
Files 58 58
Lines 1006 1006
============================================
+ Hits 943 948 +5
+ Misses 63 58 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fain182
reviewed
Aug 17, 2022
| $this->assertEquals($expected, $this->violationStore->toString()); | ||
| } | ||
|
|
||
| public function test_get_iterable(): void |
Collaborator
There was a problem hiding this comment.
I suppose that the type checker already check this?
Member
Author
There was a problem hiding this comment.
Yes, I was trying to explicit it well. I would like to be more specific, any suggestions @fain182 ?
Member
Author
There was a problem hiding this comment.
@fain182 I changed the assertion with a more proper one, what do you think?
AlessandroMinoccheri
force-pushed
the
add-violations-tests-not-covered
branch
from
da8117f to
2476868
Compare
AlessandroMinoccheri
force-pushed
the
add-violations-tests-not-covered
branch
from
2476868 to
3159927
Compare
fain182
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.