added check dependencies for properties (#308)

Author: AlessandroMinoccheri

src/Analyzer/FileVisitor.php

@@ -134,6 +134,24 @@ public function enterNode(Node $node): void
             }
         }
 
+        /**
+         * matches parameters dependency in property definitions like
+         * public NotBlank $foo;.
+         *
+         * @see FileVisitorTest::test_it_parse_typed_property
+         */
+        if ($node instanceof Node\Stmt\Property && null !== $this->classDescriptionBuilder) {
+            if (null === $node->type) {
+                return;
+            }
+
+            if (!method_exists($node->type, 'toString')) {
+                return;
+            }
+
+            $this->classDescriptionBuilder->addDependency(new ClassDependency($node->type->toString(), $node->getLine()));
+        }
+
         if (null !== $this->classDescriptionBuilder && null !== $node->getDocComment()) {
             /** @var Doc $docComment */
             $docComment = $node->getDocComment();

tests/E2E/_fixtures/mvc/Services/CartService.php

@@ -3,8 +3,6 @@
 
 namespace App\Services;
 
-use ContainerAwareInterface;
-
-class CartService implements ContainerAwareInterface
+class CartService implements \ContainerAwareInterface
 {
 }

tests/E2E/_fixtures/mvc/Services/Foo/Bar.php

@@ -3,8 +3,6 @@
 
 namespace App\Services\Foo;
 
-use ContainerAwareInterface;
-
-class Bar implements ContainerAwareInterface
+class Bar implements \ContainerAwareInterface
 {
 }

tests/Unit/Analyzer/FileVisitorTest.php

@@ -523,4 +523,32 @@ public function getFoo(): int
 
         $this->assertCount(2, $violations);
     }
+
+    public function test_it_parse_typed_property(): void
+    {
+        $code = <<< 'EOF'
+<?php
+namespace MyProject\AppBundle\Application;
+
+use Symfony\Component\Validator\Constraints\NotBlank;
+
+class ApplicationLevelDto
+{
+    public NotBlank $foo;
+}
+EOF;
+
+        /** @var FileParser $fp */
+        $fp = FileParserFactory::createFileParser(TargetPhpVersion::create('8.1'));
+        $fp->parse($code, 'relativePathName');
+
+        $cd = $fp->getClassDescriptions();
+
+        $violations = new Violations();
+
+        $notHaveDependencyOutsideNamespace = new DependsOnlyOnTheseNamespaces('MyProject\AppBundle\Application');
+        $notHaveDependencyOutsideNamespace->evaluate($cd[0], $violations, 'we want to add this rule for our software');
+
+        $this->assertCount(1, $violations);
+    }
 }