Skip to content

Fix NRE in mock debug log for native commands #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2024
Merged

Fix NRE in mock debug log for native commands #2480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46929f7
Fix NRE in mock debug log for native commands
fflaten May 21, 2024
0451f6e
Exclude for commands without parameters
fflaten May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/functions/Mock.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,10 @@ function Should-InvokeInternal {
$nonMatchingCalls = [System.Collections.Generic.List[object]]@()

# Check for variables in ParameterFilter that already exists in session. Risk of conflict
if ($PesterPreference.Debug.WriteDebugMessages.Value) {
# Excluding native applications as they don't have parameters or metadata. Will always use $args
if ($PesterPreference.Debug.WriteDebugMessages.Value -and
$null -ne $ContextInfo.Hook.Metadata -and
$ContextInfo.Hook.Metadata.Parameters.Count -gt 0) {
$preExistingFilterVariables = @{}
foreach ($v in $filter.Ast.FindAll( { $args[0] -is [System.Management.Automation.Language.VariableExpressionAst] }, $true)) {
if (-not $preExistingFilterVariables.ContainsKey($v.VariablePath.UserPath)) {
Expand Down