Fix NRE in mock debug log for native commands #2480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
While at it, let's save AST-processing for parameter-less functions as well. |
Collaborator
Author
|
/backport to rel/5.6.x |
|
Started backporting to rel/5.6.x: https://github.com/pester/Pester/actions/runs/9177190930 |
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes NRE using mock debug logging when
Should-Invokewith-ParameterFilteris used for a mocked native application. Caused by variable conflict-logging looking for CommandMetaData which doesn't exist for external commands = N/A logging.Fix #2479
Backport to 5.6.0
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.