Desktop: Fixes laurent22#13745: Use the native CodeMirror clipboard handler for copy/cut/paste

Author: personalizedrefrigerator

.eslintignore

@@ -1007,7 +1007,7 @@ packages/editor/CodeMirror/CodeMirrorControl.js
 packages/editor/CodeMirror/configFromSettings.js
 packages/editor/CodeMirror/createEditor.test.js
 packages/editor/CodeMirror/createEditor.js
-packages/editor/CodeMirror/editorCommands/cutOrCopyText.js
+packages/editor/CodeMirror/editorCommands/clipboardCommand.js
 packages/editor/CodeMirror/editorCommands/duplicateLine.test.js
 packages/editor/CodeMirror/editorCommands/duplicateLine.js
 packages/editor/CodeMirror/editorCommands/editorCommands.js

.gitignore

@@ -979,7 +979,7 @@ packages/editor/CodeMirror/CodeMirrorControl.js
 packages/editor/CodeMirror/configFromSettings.js
 packages/editor/CodeMirror/createEditor.test.js
 packages/editor/CodeMirror/createEditor.js
-packages/editor/CodeMirror/editorCommands/cutOrCopyText.js
+packages/editor/CodeMirror/editorCommands/clipboardCommand.js
 packages/editor/CodeMirror/editorCommands/duplicateLine.test.js
 packages/editor/CodeMirror/editorCommands/duplicateLine.js
 packages/editor/CodeMirror/editorCommands/editorCommands.js

packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/CodeMirror.tsx

@@ -107,7 +107,7 @@ const CodeMirror = (props: NoteBodyEditorProps, ref: ForwardedRef<NoteBodyEditor
 	const editorPasteText = useCallback(async () => {
 		if (editorRef.current) {
 			const modifiedMd = await Note.replaceResourceExternalToInternalLinks(clipboard.readText(), { useAbsolutePaths: true });
-			editorRef.current.insertText(modifiedMd, UserEventSource.Paste);
+			editorRef.current.pasteText(modifiedMd);
 		}
 	}, []);
 

packages/editor/CodeMirror/CodeMirrorControl.ts

@@ -16,7 +16,7 @@ import jumpToHash from './editorCommands/jumpToHash';
 import { resetImageResourceEffect } from './extensions/rendering/renderBlockImages';
 import Logger from '@joplin/utils/Logger';
 import { searchChangeSourceEffect } from './extensions/searchExtension';
-import cutOrCopyText, { ClipboardAction } from './editorCommands/cutOrCopyText';
+import clipboardCommand, { ClipboardActionType } from './editorCommands/clipboardCommand';
 
 const logger = Logger.create('CodeMirrorControl');
 
@@ -261,12 +261,25 @@ export default class CodeMirrorControl extends CodeMirror5Emulation implements E
 		this._callbacks.onRemove();
 	}
 
-	public cutText(writeClipboard: (text: string)=> void) {
-		return cutOrCopyText(writeClipboard, ClipboardAction.Cut)(this.editor);
+	public cutText(onWriteClipboard: (text: string)=> void) {
+		return clipboardCommand({
+			onWriteClipboard,
+			type: ClipboardActionType.Cut,
+		})(this.editor);
 	}
 
-	public copyText(writeClipboard: (text: string)=> void) {
-		return cutOrCopyText(writeClipboard, ClipboardAction.Copy)(this.editor);
+	public copyText(onWriteClipboard: (text: string)=> void) {
+		return clipboardCommand({
+			onWriteClipboard,
+			type: ClipboardActionType.Copy,
+		})(this.editor);
+	}
+
+	public pasteText(text: string) {
+		return clipboardCommand({
+			text,
+			type: ClipboardActionType.Paste,
+		})(this.editor);
 	}
 
 	//

packages/editor/CodeMirror/editorCommands/clipboardCommand.ts

@@ -0,0 +1,40 @@
+import { Command } from '@codemirror/view';
+
+export enum ClipboardActionType {
+	Cut = 'cut',
+	Copy = 'copy',
+	Paste = 'paste',
+}
+
+interface PasteAction {
+	type: ClipboardActionType.Paste;
+	text: string;
+}
+
+type OnWriteClipboard = (text: string)=> void;
+interface CopyAction {
+	type: ClipboardActionType.Copy|ClipboardActionType.Cut;
+	onWriteClipboard: OnWriteClipboard;
+}
+
+type ClipboardAction = CopyAction|PasteAction;
+
+const clipboardCommand = (action: ClipboardAction): Command => (view) => {
+	const clipboardData = new DataTransfer();
+	if (action.type === ClipboardActionType.Paste) {
+		clipboardData.setData('text/plain', action.text);
+	}
+	const event = new ClipboardEvent(action.type, {
+		clipboardData,
+	});
+	view.contentDOM.dispatchEvent(event);
+
+	const data = clipboardData.getData('text/plain');
+	if (data && action.type !== ClipboardActionType.Paste) {
+		action.onWriteClipboard(data);
+	}
+
+	return true;
+};
+
+export default clipboardCommand;