Skip to content

Conversation

@hamzaozturk
Copy link

Summary

  • Fix TLV encoding for private message content so payloads larger than 255 bytes are accepted.
  • Keep messageId constrained to the original single-byte length while expanding only the content field to a two-byte length when needed.

@jackjackbits
Copy link
Collaborator

this is a protocol breaking change that we need to sync with android. it also has an error when message is exactly 255 chars. and no tests.

@hamzaozturk
Copy link
Author

hamzaozturk commented Oct 10, 2025

Is there any particular reason why private messages are limited to 255 characters? Just wondering if that’s intentional.
Also, I’ve fixed the 255-char issue you mentioned and added the relevant tests for it.

@jackjackbits jackjackbits requested a review from callebtc October 10, 2025 10:11
@jackjackbits
Copy link
Collaborator

jackjackbits commented Oct 10, 2025 via email

HAMZA OZTURK - Mobil Operasyonel Cozumler Mudurlugu and others added 2 commits November 1, 2025 22:34
@hamzaozturk hamzaozturk force-pushed the fix/private-message-content-length branch from eb9bc80 to cbdc880 Compare November 1, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants