iframe waitForText null

Author: travagliad

tests/QAN/filters_test.js

@@ -198,9 +198,7 @@ Scenario(
     queryAnalyticsPage.filters.selectContainFilter(serviceName);
     queryAnalyticsPage.data.waitForNewItemsCount(count);
     queryAnalyticsPage.filters.selectFilterInGroup(db2, section);
-    await within(queryAnalyticsPage.data.root, () => {
-      I.waitForText('No queries available for this combination of filters', 30);
-    });
+    I.waitForText('No queries available for this combination of filters', 30);
   },
 ).retry(2);
 

tests/helper/hooks.js

@@ -5,6 +5,8 @@ const { event, container } = require('codeceptjs');
 function getSelector(locator) {
   let selector = locator;
 
+  if (!locator) return null;
+
   if (typeof locator === 'object') {
     if (locator.xpath) {
       selector = `xpath=${locator.xpath}`;
@@ -139,7 +141,7 @@ module.exports = function pmmGrafanaIframeHook() {
   applyContextOverride(helper, 'grabTextFrom', async (locator) => helper.context.locator(getSelector(locator)).first().textContent());
   applyContextOverride(helper, 'grabTextFromAll', async (locator) => helper.context.locator(getSelector(locator)).allTextContents());
   applyContextOverride(helper, 'waitForText', async (text, seconds = null, context = null) => {
-    await helper.context.locator(getSelector(context)).filter({ hasText: text }).first().waitFor({
+    await helper.context.locator(getSelector(context) || 'body').filter({ hasText: text }).first().waitFor({
       state: 'visible',
       timeout: seconds ? seconds * 1000 : helper.options.waitForTimeout,
     });