Fix for JKT check #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion, as they require different things added the 'ath' check in the validateJwtDpop method moved the 'jkt' check to the validateIdTokenDpop method fixed the tests to use a correct jwt access token (instead of just putting the dpop token there as well)
Potherca
commented
Sep 29, 2022
fixed @returns at validateDpop add $this->markTestSkipped for 3 tests that are probably incorrect
Member
Author
|
As the GitHub UI is telling me that:
I am adding my seal of approval here.
|
ylebre
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of various OICD related JWT checks.