Add sdkSource to button props #2565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbierdeman
reviewed
Sep 22, 2025
src/zoid/buttons/component.jsx
Outdated
|
|
||
| sdkSource: { | ||
| type: "string", | ||
| value: () => { |
Contributor
There was a problem hiding this comment.
I think the short form would work here, since sdkSourceValue isn't used anywhere else (and increases memory usage for a time):
Suggested change
| value: () => { | |
| value: () => getSDKIntegrationSource(), |
jtanya17
approved these changes
Sep 23, 2025
ravishekhar
approved these changes
Sep 23, 2025
|
|
||
| sdkSource: { | ||
| type: "string", | ||
| value: () => getSDKIntegrationSource(), |
Contributor
There was a problem hiding this comment.
nit : There is generally no specific reason to create an inline function here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
To support observability for BT JS SDK app-switch integration, the following query parameters must be included in the app switch universal link:
source: bsdk
merchant: id of merchant
flow_type: va/ecs
Jira Ticket: https://paypal.atlassian.net/browse/DTNFSPEED-518
This change was based on the signoff provided as stated in this confluence ,
https://paypal.atlassian.net/wiki/spaces/~712020bf3722d704414ecfa7688c73d80a4e73/pages/2693601182/Proposed+solution+to+add+new+params+to+Universal+appswitch+link
Test Recording Video
https://github.com/user-attachments/assets/5483c41b-ef48-428a-98d2-7ab4ae16c141