-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: publish button incorrectly shown after saving draft when access denied #15319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
…-permissions-after-draft-save
…-permissions-after-draft-save
AlessioGr
approved these changes
Jan 23, 2026
Contributor
|
🚀 This is included in version v3.74.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes publish and unpublish buttons incorrectly appearing for users without publish permissions after saving a draft.
Why
The document access endpoints weren't passing request body data to the permission operations.
This caused the simulated
_statusfield (used to check "can this user publish?") to be ignored. The frontend simulates_status: 'published'to determine if the publish button should be shown, but the backend would check permissions against the actual draft document instead, incorrectly returningtrue.This made the publish button visible even though clicking it would still fail with an access error.
Additionally, the unpublish button didn't check for publish permissions at all - if a user can't publish, they shouldn't be able to unpublish either.
How
data: req.datain collection and globaldocAccessendpoint handlers so simulated status is used for permission checksuseGetDocPermissionsto extract actual document from API response (data?.doc || data || {}) before sending to backend, ensuring field permissions receive complete document structurehasPublishPermissioncheck toUnpublishButtoncomponentFixes #15312