fix(ui): relationship add button unsafe permissions property access #14903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronClaes
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
Contributor
|
🚀 This is included in version v3.68.4 |
zubricks
pushed a commit
that referenced
this pull request
Jan 6, 2026
…14903) ### What? Fix crashing due to unsafe permissions property access in `AddNewRelation` by safely checking that a collection’s permissions exist before reading its `create` property. ### Why? Accessing `permissions.collections[slug].create` throws and breaks the UI when a collection’s permissions entry is missing. This happens for example when collection‑level access control makes that collection inaccessible. ### How? Change the condition to use optional chaining on the permissions, aligning with usage elsewhere in the codebase: - Before: `permissions.collections[relatedCollection?.slug].create` - After: `permissions.collections[relatedCollection?.slug]?.create`
teastudiopl
pushed a commit
to teastudiopl/payload
that referenced
this pull request
Jan 8, 2026
…ayloadcms#14903) ### What? Fix crashing due to unsafe permissions property access in `AddNewRelation` by safely checking that a collection’s permissions exist before reading its `create` property. ### Why? Accessing `permissions.collections[slug].create` throws and breaks the UI when a collection’s permissions entry is missing. This happens for example when collection‑level access control makes that collection inaccessible. ### How? Change the condition to use optional chaining on the permissions, aligning with usage elsewhere in the codebase: - Before: `permissions.collections[relatedCollection?.slug].create` - After: `permissions.collections[relatedCollection?.slug]?.create`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix crashing due to unsafe permissions property access in
AddNewRelationby safely checking that a collection’s permissions exist before reading itscreateproperty.Why?
Accessing
permissions.collections[slug].createthrows and breaks the UI when a collection’s permissions entry is missing.This happens for example when collection‑level access control makes that collection inaccessible.
How?
Change the condition to use optional chaining on the permissions, aligning with usage elsewhere in the codebase:
permissions.collections[relatedCollection?.slug].createpermissions.collections[relatedCollection?.slug]?.create