Skip to content

test: deflake sort e2e#14746

Merged
jacobsfletch merged 2 commits into
mainfrom
test/deflake-sort
Nov 27, 2025
Merged

test: deflake sort e2e#14746
jacobsfletch merged 2 commits into
mainfrom
test/deflake-sort

Conversation

@jacobsfletch
Copy link
Copy Markdown
Member

The sort e2e test suite was flaky in both CI and locally.

Reference: https://github.com/payloadcms/payload/actions/runs/19707665246/job/56460054510?pr=14117

@github-actions
Copy link
Copy Markdown
Contributor

📦 esbuild Bundle Analysis for payload

This analysis was generated by esbuild-bundle-analyzer. 🤖
This PR introduced no changes to the esbuild bundle! 🙌

Comment thread test/sort/e2e.spec.ts
@jacobsfletch jacobsfletch marked this pull request as ready for review November 26, 2025 19:40
Comment thread test/sort/e2e.spec.ts
@jacobsfletch jacobsfletch enabled auto-merge (squash) November 26, 2025 19:48
Comment thread test/sort/e2e.spec.ts
Comment on lines +132 to +134
await assertRows(['A', 'B', 'C', 'D'], {
scope: page.locator('#field-orderableJoinField1'),
})
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, but nth seemed more declarative to me than passing a locator : )

Copy link
Copy Markdown
Contributor

@GermanJablo GermanJablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jacobsfletch jacobsfletch merged commit a07cf47 into main Nov 27, 2025
98 checks passed
@jacobsfletch jacobsfletch deleted the test/deflake-sort branch November 27, 2025 15:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 3, 2025

🚀 This is included in version v3.66.0

zubricks pushed a commit that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants