feature: withContextMenu support for Promise#58
Conversation
There was a problem hiding this comment.
Logic looks good and works as expected @jeff-phillips-18 !
Wondering if you think it'd be worth adding some text (similar to the Uncontrolled Context Menu example) which states that you can access the context menu on a node by ctrl + click
|
@jenny-s51 It's the same as the previous example. ctrl-click or right-click will trigger the context menu. This is standard DOM element behavior using the |
jenny-s51
left a comment
There was a problem hiding this comment.
@jeff-phillips-18 definitely makes sense - thought this was some additional logic built into topology. Right clicking via mouse works as expected, I tested via trackpad, and ctrl + clicking is right click behavior. Thanks for clarifying , LGTM
|
🎉 This PR is included in version 5.0.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What
Closes #15
Description
Allows the use of a Promise when determining the context menu items when using
withContextMenuType of change
Screen shots / Gifs for design review
/cc @jshaughn