feat: generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed by musthafa1996 · Pull Request #1540 · parse-community/Parse-SDK-JS

musthafa1996 · 2022-09-04T10:10:10Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Enabling allowCustomObjectId forces all objects to have custom objectIds instead of auto-generating when no objectId is passed, or when objectId is null or undefined.

Related issue: #1402

Approach

When allowCustomObjectId is enabled:

Check if objectId has a custom value.
If objectId has a value and is an empty string, throw 'objectId must not be empty' error.
If objectId doesn't have a value, or is null or undefined, generate objectId automatically as if allowCustomObjectId were disabled.

TODOs before merging

[x ] Add tests
Add entry to changelog
Add changes to documentation (guides, repository pages, in-code descriptions)

…mObjectId is enabled

parse-github-assistant · 2022-09-04T10:10:12Z

I will reformat the title to use the proper commit message syntax.

parse-github-assistant · 2022-09-04T10:10:15Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

codecov · 2022-09-04T12:09:30Z

Codecov Report

Base: 99.94% // Head: 99.94% // No change to project coverage 👍

Coverage data is based on head (c5cc568) compared to base (d3ca00d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha    #1540   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          61       61           
  Lines        5955     5955           
  Branches     1360     1360           
=======================================
  Hits         5952     5952           
  Misses          3        3

Impacted Files	Coverage Δ
src/ParseObject.js	`99.89% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

dblythy

Looks mostly good, just some minor refactoring

Co-authored-by: dblythy <daniel-blyth@live.com.au>

musthafa1996 · 2022-09-05T06:41:40Z

Thanks for reviewing @dblythy! I have refactored the tests with your suggestions. Can you check again please?

musthafa1996 · 2022-09-06T08:58:45Z

Hi @dblythy! Were you able to have a look at the recent changes pushed to the PR?

dblythy · 2022-09-06T09:01:41Z

You might need to run npm run lint and fix syntax errors. I couldn't suggest changes to be syntactically correct as I couldn't provide suggestions across deleted lines.

musthafa1996 · 2022-09-06T10:12:45Z

You might need to run npm run lint and fix syntax errors. I couldn't suggest changes to be syntactically correct as I couldn't provide suggestions across deleted lines.

Thanks. I’ll run and post the results.

musthafa1996 · 2022-09-06T10:23:38Z

@dblythy, my bad. I have just fixed the syntax error and updated the PR. Please have a look now.

The following is the result of npm run lint:

The following is the result of npm run test:

dblythy

Sorry, I just worked out how to properly suggest 😂.

Almost there, @mtrezza can you allow the tests to run?

musthafa1996 · 2022-09-06T12:37:44Z

I had been careful enough this time while refactoring. Can you check yet again, @dblythy ? :)

musthafa1996 · 2022-09-07T13:46:09Z

@mtrezza, @dblythy, have you checked the latest changes?

dblythy · 2022-09-07T17:26:27Z

I will review again within 24 hrs 😊

musthafa1996 · 2022-09-07T17:28:07Z

Thank you 😊

dblythy · 2022-09-08T01:31:38Z

Can you check the integration check? npm run integration

…ustomObjectId is true

musthafa1996 · 2022-09-09T20:40:28Z

Can you check the integration check? npm run integration

Hi @dblythy and @mtrezza! I did get some time to look into this PR today. I have pushed the following updates:

Remove unnecessary id existence check from ParseObject in case allowCustomObjectId is true.
Fix tests for allowCustomObjectId.

Turns out that we don't need the following checks in ParseObject as they are already validated from ParseServer.

All the related tests seem to work fine now.

musthafa1996 · 2022-09-19T11:09:45Z

What's pending for this PR to be merged now @dblythy, @mtrezza?

…S into allow-custom-id

mtrezza · 2022-09-21T09:55:26Z

Waiting for CI to pass

musthafa1996 · 2022-09-21T10:01:01Z

CI has been completed successfully.

mtrezza

Looks good!

mtrezza · 2022-09-21T12:42:48Z

@dblythy Is this ready for merge also from your side?

# [3.5.0-alpha.4](3.5.0-alpha.3...3.5.0-alpha.4) (2022-09-21) ### Features * generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5))

parseplatformorg · 2022-09-21T20:54:18Z

🎉 This change has been released in version 3.5.0-alpha.4

musthafa1996 · 2022-09-22T06:33:21Z

Thanks for merging @mtrezza and @dblythy :)

dblythy · 2022-09-22T07:25:28Z

Thanks for your contribution!! 🔥

musthafa1996 · 2022-09-24T20:51:53Z

Hi @mtrezza! When can we expect version 3.5.0 to be released?

mtrezza · 2022-09-24T23:24:23Z

The release cycle is monthly (around the beginning of every month): alpha -> beta -> release
This feature will be in beta in Okt. and in stable release in Nov.

musthafa1996 · 2022-09-24T23:31:37Z

Got it. Thanks for letting me know @mtrezza 😊

# [3.5.0-beta.1](3.4.4...3.5.0-beta.1) (2022-10-25) ### Bug Fixes * `Parse.User.signUp()` does not pass context to Cloud Code ([#1527](#1527)) ([53edcfd](53edcfd)) * `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7)) * creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862)) * initialization fails in non-browser environment that doesn't support `indexedDB` ([#1569](#1569)) ([3560a5e](3560a5e)) * remove base64 validation due to validation inefficiency ([#1543](#1543)) ([473949d](473949d)) ### Features * add `json` option to `Parse.Query.each()` ([#1539](#1539)) ([89fd5ec](89fd5ec)) * add json option to query.each ([299fb0d](299fb0d)) * generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5)) * localDatastore support for unsorted distance queries ([#1570](#1570)) ([ea3e75f](ea3e75f))

parseplatformorg · 2022-10-25T22:20:52Z

🎉 This change has been released in version 3.5.0-beta.1

# [3.5.0](3.4.4...3.5.0) (2022-11-01) ### Bug Fixes * `Parse.User.signUp()` does not pass context to Cloud Code ([#1527](#1527)) ([53edcfd](53edcfd)) * `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7)) * creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862)) * initialization fails in non-browser environment that doesn't support `indexedDB` ([#1569](#1569)) ([3560a5e](3560a5e)) * remove base64 validation due to validation inefficiency ([#1543](#1543)) ([473949d](473949d)) ### Features * add `json` option to `Parse.Query.each()` ([#1539](#1539)) ([89fd5ec](89fd5ec)) * add json option to query.each ([299fb0d](299fb0d)) * generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5)) * localDatastore support for unsorted distance queries ([#1570](#1570)) ([ea3e75f](ea3e75f))

parseplatformorg · 2022-11-01T21:43:49Z

🎉 This change has been released in version 3.5.0

* `Parse.User.signUp()` does not pass context to Cloud Code ([#1527](#1527)) ([53edcfd](53edcfd)) * `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7)) * creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862)) * initialization fails in non-browser environment that doesn't support `indexedDB` ([#1569](#1569)) ([3560a5e](3560a5e)) * remove base64 validation due to validation inefficiency ([#1543](#1543)) ([473949d](473949d)) * add `json` option to `Parse.Query.each()` ([#1539](#1539)) ([89fd5ec](89fd5ec)) * add json option to query.each ([299fb0d](299fb0d)) * generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5)) * localDatastore support for unsorted distance queries ([#1570](#1570)) ([ea3e75f](ea3e75f))

musthafa1996 added 3 commits September 4, 2022 13:43

feat: Update conditions for MISSING_OBJECT_ID error when allowCusto…

78729bb

…mObjectId is enabled

Update MISSING_OBJECT_ID error message

a88e8ae

Update tests

ec80a44

parse-github-assistant Bot changed the title ~~feat: Generate Parse.Object.objectId automatically when allowCustomObjectId is enabled and no objectId is passed~~ feat: generate Parse.Object.objectId automatically when allowCustomObjectId is enabled and no objectId is passed Sep 4, 2022

musthafa1996 mentioned this pull request Sep 4, 2022

Option allowCustomObjectId forces all objects to have custom objectId #1402

Closed

mtrezza linked an issue Sep 4, 2022 that may be closed by this pull request

Option allowCustomObjectId forces all objects to have custom objectId #1402

Closed

mtrezza requested a review from a team September 4, 2022 12:19

dblythy suggested changes Sep 5, 2022

View reviewed changes

Comment thread integration/test/ParseObjectTest.js Outdated

Comment thread integration/test/ParseObjectTest.js Outdated

musthafa1996 and others added 2 commits September 5, 2022 12:10

Update integration/test/ParseObjectTest.js

2298855

Co-authored-by: dblythy <daniel-blyth@live.com.au>

Update integration/test/ParseObjectTest.js

b3b3365

Co-authored-by: dblythy <daniel-blyth@live.com.au>

Fix tests

91e425f

dblythy suggested changes Sep 6, 2022

View reviewed changes

Comment thread integration/test/ParseObjectTest.js Outdated

Comment thread integration/test/ParseObjectTest.js Outdated

Fix tests for custom object ID

2455fcb

mtrezza and others added 3 commits September 9, 2022 01:32

Merge branch 'alpha' into allow-custom-id

9f53d1a

Remove unnecessary id existence check from ParseObject in case allowC…

872aadb

…ustomObjectId is true

Fix tests for allowCustomObjectId

43e96b3

Merge branch 'alpha' into allow-custom-id

6bbb054

dblythy approved these changes Sep 19, 2022

View reviewed changes

mtrezza requested changes Sep 19, 2022

View reviewed changes

Comment thread integration/test/ParseObjectTest.js Outdated

musthafa1996 and others added 3 commits September 21, 2022 15:15

Split ParseOnject allowCustomObjectId integration tests

7e3b18f

Merge branch 'allow-custom-id' of github.com:musthafa1996/Parse-SDK-J…

04748d6

…S into allow-custom-id

Merge branch 'alpha' into allow-custom-id

7362468

mtrezza approved these changes Sep 21, 2022

View reviewed changes

Merge branch 'alpha' into allow-custom-id

c5cc568

dblythy approved these changes Sep 21, 2022

View reviewed changes

mtrezza merged commit 68f3ff5 into parse-community:alpha Sep 21, 2022

parseplatformorg added the state:released-alpha Released as alpha version label Sep 21, 2022

musthafa1996 deleted the allow-custom-id branch September 22, 2022 06:33

parseplatformorg added the state:released-beta Released as beta version label Oct 25, 2022

parseplatformorg added the state:released Released as stable version label Nov 1, 2022

Uh oh!

Conversation

musthafa1996 commented Sep 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

Uh oh!

parse-github-assistant Bot commented Sep 4, 2022

Uh oh!

parse-github-assistant Bot commented Sep 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for opening this pull request!

Uh oh!

codecov Bot commented Sep 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dblythy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

musthafa1996 commented Sep 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

musthafa1996 commented Sep 6, 2022

Uh oh!

dblythy commented Sep 6, 2022

Uh oh!

musthafa1996 commented Sep 6, 2022

Uh oh!

musthafa1996 commented Sep 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dblythy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

musthafa1996 commented Sep 6, 2022

Uh oh!

musthafa1996 commented Sep 7, 2022

Uh oh!

dblythy commented Sep 7, 2022

Uh oh!

musthafa1996 commented Sep 7, 2022

Uh oh!

dblythy commented Sep 8, 2022

Uh oh!

musthafa1996 commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

musthafa1996 commented Sep 19, 2022

Uh oh!

Uh oh!

mtrezza commented Sep 21, 2022

Uh oh!

musthafa1996 commented Sep 21, 2022

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

mtrezza commented Sep 21, 2022

Uh oh!

parseplatformorg commented Sep 21, 2022

Uh oh!

musthafa1996 commented Sep 22, 2022

Uh oh!

dblythy commented Sep 22, 2022

Uh oh!

musthafa1996 commented Sep 24, 2022

Uh oh!

mtrezza commented Sep 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

musthafa1996 commented Sep 24, 2022

Uh oh!

parseplatformorg commented Oct 25, 2022

musthafa1996 commented Sep 4, 2022 •

edited

Loading

parse-github-assistant Bot commented Sep 4, 2022 •

edited

Loading

codecov Bot commented Sep 4, 2022 •

edited

Loading

musthafa1996 commented Sep 5, 2022 •

edited

Loading

musthafa1996 commented Sep 6, 2022 •

edited

Loading

musthafa1996 commented Sep 9, 2022 •

edited

Loading

mtrezza commented Sep 24, 2022 •

edited

Loading