fix: creating a Parse.File with base64 string fails for some encodings#1517
Merged
mtrezza merged 3 commits intoparse-community:alphafrom Jul 28, 2022
justinlettau:fix-base64-regex
Merged
fix: creating a Parse.File with base64 string fails for some encodings#1517mtrezza merged 3 commits intoparse-community:alphafrom justinlettau:fix-base64-regex
mtrezza merged 3 commits intoparse-community:alphafrom
justinlettau:fix-base64-regex
Conversation
Thanks for opening this pull request!
|
4 tasks
justinlettau
changed the title
mtrezza
changed the title
4 tasks
mtrezza
requested changes
Jul 28, 2022
Codecov Report
@@ Coverage Diff @@
## alpha #1517 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 61 61
Lines 5955 5955
Branches 1358 1358
=======================================
Hits 5952 5952
Misses 3 3
Continue to review full report at Codecov.
|
Member
mtrezza
changed the title
mtrezza
changed the title
Contributor
|
🎉 This change has been released in version 3.4.4-alpha.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Oct 25, 2022
# [3.5.0-beta.1](3.4.4...3.5.0-beta.1) (2022-10-25) ### Bug Fixes * `Parse.User.signUp()` does not pass context to Cloud Code ([#1527](#1527)) ([53edcfd](53edcfd)) * `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7)) * creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862)) * initialization fails in non-browser environment that doesn't support `indexedDB` ([#1569](#1569)) ([3560a5e](3560a5e)) * remove base64 validation due to validation inefficiency ([#1543](#1543)) ([473949d](473949d)) ### Features * add `json` option to `Parse.Query.each()` ([#1539](#1539)) ([89fd5ec](89fd5ec)) * add json option to query.each ([299fb0d](299fb0d)) * generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5)) * localDatastore support for unsorted distance queries ([#1570](#1570)) ([ea3e75f](ea3e75f))
Contributor
|
🎉 This change has been released in version 3.5.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Nov 1, 2022
# [3.5.0](3.4.4...3.5.0) (2022-11-01) ### Bug Fixes * `Parse.User.signUp()` does not pass context to Cloud Code ([#1527](#1527)) ([53edcfd](53edcfd)) * `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7)) * creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862)) * initialization fails in non-browser environment that doesn't support `indexedDB` ([#1569](#1569)) ([3560a5e](3560a5e)) * remove base64 validation due to validation inefficiency ([#1543](#1543)) ([473949d](473949d)) ### Features * add `json` option to `Parse.Query.each()` ([#1539](#1539)) ([89fd5ec](89fd5ec)) * add json option to query.each ([299fb0d](299fb0d)) * generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5)) * localDatastore support for unsorted distance queries ([#1570](#1570)) ([ea3e75f](ea3e75f))
Contributor
|
🎉 This change has been released in version 3.5.0 |
mtrezza
pushed a commit
that referenced
this pull request
Nov 3, 2022
* `Parse.User.signUp()` does not pass context to Cloud Code ([#1527](#1527)) ([53edcfd](53edcfd)) * `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7)) * creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862)) * initialization fails in non-browser environment that doesn't support `indexedDB` ([#1569](#1569)) ([3560a5e](3560a5e)) * remove base64 validation due to validation inefficiency ([#1543](#1543)) ([473949d](473949d)) * add `json` option to `Parse.Query.each()` ([#1539](#1539)) ([89fd5ec](89fd5ec)) * add json option to query.each ([299fb0d](299fb0d)) * generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5)) * localDatastore support for unsorted distance queries ([#1570](#1570)) ([ea3e75f](ea3e75f))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Related issue: #1510
Approach
Adding a failing unit test for reproducing base64 regex issue.
TODOs before merging