From 5becc1c384064ca6a0e87053b1b062a98d3a072a Mon Sep 17 00:00:00 2001 From: Alexandru Cihodaru Date: Fri, 28 Nov 2025 08:23:59 +0200 Subject: [PATCH 1/6] Accept custom capacity for block notifier buffer Signed-off-by: Alexandru Cihodaru --- substrate/frame/revive/rpc/src/client.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/substrate/frame/revive/rpc/src/client.rs b/substrate/frame/revive/rpc/src/client.rs index 2557e9b97d16b..253800c49d489 100644 --- a/substrate/frame/revive/rpc/src/client.rs +++ b/substrate/frame/revive/rpc/src/client.rs @@ -257,8 +257,8 @@ impl Client { } /// Creates a block notifier instance. - pub fn create_block_notifier(&mut self) { - self.block_notifier = Some(tokio::sync::broadcast::channel::(NOTIFIER_CAPACITY).0); + pub fn create_block_notifier(&mut self, capacity: Option) { + self.block_notifier = Some(tokio::sync::broadcast::channel::(capacity.unwrap_or(NOTIFIER_CAPACITY)).0); } /// Subscribe to past blocks executing the callback for each block in `range`. From f89167b8bbb97a0efc64a7e906db635d8ba05577 Mon Sep 17 00:00:00 2001 From: "cmd[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 28 Nov 2025 06:54:03 +0000 Subject: [PATCH 2/6] Update from github-actions[bot] running command 'prdoc --audience runtime_dev --bump patch' --- prdoc/pr_10451.prdoc | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 prdoc/pr_10451.prdoc diff --git a/prdoc/pr_10451.prdoc b/prdoc/pr_10451.prdoc new file mode 100644 index 0000000000000..c427fa436105f --- /dev/null +++ b/prdoc/pr_10451.prdoc @@ -0,0 +1,7 @@ +title: Accept custom capacity for block notifier buffer +doc: +- audience: Runtime Dev + description: When creating a block notifier allow setting a custom capacity +crates: +- name: pallet-revive-eth-rpc + bump: patch From 320a0dc70c85606529bc1cb76c26f064662d5129 Mon Sep 17 00:00:00 2001 From: "cmd[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 28 Nov 2025 07:12:50 +0000 Subject: [PATCH 3/6] Update from github-actions[bot] running command 'fmt' --- substrate/frame/revive/rpc/src/client.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/substrate/frame/revive/rpc/src/client.rs b/substrate/frame/revive/rpc/src/client.rs index 253800c49d489..25d28760e71e1 100644 --- a/substrate/frame/revive/rpc/src/client.rs +++ b/substrate/frame/revive/rpc/src/client.rs @@ -258,7 +258,8 @@ impl Client { /// Creates a block notifier instance. pub fn create_block_notifier(&mut self, capacity: Option) { - self.block_notifier = Some(tokio::sync::broadcast::channel::(capacity.unwrap_or(NOTIFIER_CAPACITY)).0); + self.block_notifier = + Some(tokio::sync::broadcast::channel::(capacity.unwrap_or(NOTIFIER_CAPACITY)).0); } /// Subscribe to past blocks executing the callback for each block in `range`. From 45fdcec0c7a8b6bd5382a5fe80e839e476e13aba Mon Sep 17 00:00:00 2001 From: Alexandru Cihodaru Date: Fri, 28 Nov 2025 10:12:29 +0200 Subject: [PATCH 4/6] feedback v1 Signed-off-by: Alexandru Cihodaru --- substrate/frame/revive/rpc/src/client.rs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/substrate/frame/revive/rpc/src/client.rs b/substrate/frame/revive/rpc/src/client.rs index 25d28760e71e1..2516bc574ec1c 100644 --- a/substrate/frame/revive/rpc/src/client.rs +++ b/substrate/frame/revive/rpc/src/client.rs @@ -257,9 +257,13 @@ impl Client { } /// Creates a block notifier instance. - pub fn create_block_notifier(&mut self, capacity: Option) { - self.block_notifier = - Some(tokio::sync::broadcast::channel::(capacity.unwrap_or(NOTIFIER_CAPACITY)).0); + pub fn create_block_notifier(&mut self) { + self.block_notifier = Some(tokio::sync::broadcast::channel::(NOTIFIER_CAPACITY).0); + } + + /// Sets a block notifier + pub fn set_block_notifier(&mut self, notifier: Option>) { + self.block_notifier = notifier; } /// Subscribe to past blocks executing the callback for each block in `range`. From 8a39100288615f6bc18f854aa7473219dfac8331 Mon Sep 17 00:00:00 2001 From: Alexandru Cihodaru Date: Fri, 28 Nov 2025 10:30:49 +0200 Subject: [PATCH 5/6] feedback v2 Signed-off-by: Alexandru Cihodaru --- prdoc/pr_10451.prdoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prdoc/pr_10451.prdoc b/prdoc/pr_10451.prdoc index c427fa436105f..9652ba96f8906 100644 --- a/prdoc/pr_10451.prdoc +++ b/prdoc/pr_10451.prdoc @@ -1,7 +1,7 @@ title: Accept custom capacity for block notifier buffer doc: - audience: Runtime Dev - description: When creating a block notifier allow setting a custom capacity + description: Add a setter for a custom block notifier crates: - name: pallet-revive-eth-rpc bump: patch From 64ff8cc456c47e07216b62b963a0ab2d47b103ae Mon Sep 17 00:00:00 2001 From: Alexandru Cihodaru Date: Fri, 28 Nov 2025 10:33:43 +0200 Subject: [PATCH 6/6] fix prdoc Signed-off-by: Alexandru Cihodaru --- prdoc/pr_10451.prdoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prdoc/pr_10451.prdoc b/prdoc/pr_10451.prdoc index 9652ba96f8906..a6e9e77794da0 100644 --- a/prdoc/pr_10451.prdoc +++ b/prdoc/pr_10451.prdoc @@ -4,4 +4,4 @@ doc: description: Add a setter for a custom block notifier crates: - name: pallet-revive-eth-rpc - bump: patch + bump: minor