Skip to content

Commit f66f240

Browse files
TorstenStuebergithub-actions[bot]pgherveou
authored
Enable force debug in revive dev node (#10383)
This change ensures that all types that implement `RuntimeDebug` are fully displayed in log output of the revive dev node, instead of just showing `<wasm:stripped>`. Unfortunately, the trait `RuntimeDebugNoBound`, that we also use frequently in pallet-revive, is not affected and will still output `<wasm:stripped>` (it does not check for the `force-debug` feature flag, instead it only fully outputs values when either one of the features `std` or `try_runtime` is enabled – this is something we implement as a general change). --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: pgherveou <pgherveou@gmail.com>
1 parent 8c073c5 commit f66f240

3 files changed

Lines changed: 16 additions & 0 deletions

File tree

Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

prdoc/pr_10383.prdoc

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
title: Enable force debug in revive dev node
2+
doc:
3+
- audience: Runtime Dev
4+
description: "This change ensures that all types that implement `RuntimeDebug` are\
5+
\ fully displayed in log output of the revive dev node, instead of just showing\
6+
\ `<wasm:stripped>`.\n\nUnfortunately, the trait `RuntimeDebugNoBound`, that we\
7+
\ also use frequently in pallet-revive, is not affected and will still output\
8+
\ `<wasm:stripped>` (it does not check for the `force-debug` feature flag, instead\
9+
\ it only fully outputs values when either one of the features `std` or `try_runtime`\
10+
\ is enabled \u2013\_this is something we implement as a general change)."
11+
crates:
12+
- name: revive-dev-runtime
13+
bump: patch

substrate/frame/revive/dev-node/runtime/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ polkadot-sdk = { workspace = true, features = [
2525
] }
2626
scale-info = { workspace = true }
2727
serde_json = { workspace = true, default-features = false, features = ["alloc"] }
28+
sp-debug-derive = { workspace = true, features = ["force-debug"] }
2829

2930
[build-dependencies]
3031
polkadot-sdk = { optional = true, workspace = true, features = ["substrate-wasm-builder"] }
@@ -36,4 +37,5 @@ std = [
3637
"polkadot-sdk/std",
3738
"scale-info/std",
3839
"serde_json/std",
40+
"sp-debug-derive/std",
3941
]

0 commit comments

Comments
 (0)