Restrict syntax for setting ink! e2e test node to auto#2146
Merged
cmichi merged 3 commits intouse-ink:masterfrom Mar 11, 2024
davidsemakula:restrict-e2e-node-auto-syntax
Merged
Restrict syntax for setting ink! e2e test node to auto#2146cmichi merged 3 commits intouse-ink:masterfrom davidsemakula:restrict-e2e-node-auto-syntax
cmichi merged 3 commits intouse-ink:masterfrom
davidsemakula:restrict-e2e-node-auto-syntax
Conversation
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Mon Mar 11 10:15:23 CET 2024 |
cmichi
approved these changes
Mar 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2146 +/- ##
==========================================
- Coverage 53.76% 53.72% -0.05%
==========================================
Files 224 224
Lines 7084 7084
Branches 3129 3129
==========================================
- Hits 3809 3806 -3
- Misses 3275 3278 +3 ☔ View full report in Codecov by Sentry. |
Collaborator
|
@davidsemakula Can you make sure this is reflected in the 5.x part of |
ascjones
approved these changes
Mar 11, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #_
cargo-contractorpallet-contracts?Description
#[ink_e2e::test(backend(node))]and#[ink_e2e::test(backend(node(auto)))]are valid syntax for setting the e2e test node to auto, this PR removes the latter syntax.#[ink_e2e::test(backend(node(url = ..)))])See also #2143 for a similar change
Checklist before requesting a review
CHANGELOG.md