Restrict syntax for setting default ink! e2e test runtime-only emulator#2143
Merged
ascjones merged 2 commits intouse-ink:masterfrom Mar 8, 2024
davidsemakula:restrict-e2e-runtime-only-default-syntax
Merged
Restrict syntax for setting default ink! e2e test runtime-only emulator#2143ascjones merged 2 commits intouse-ink:masterfrom davidsemakula:restrict-e2e-runtime-only-default-syntax
ascjones merged 2 commits intouse-ink:masterfrom
davidsemakula:restrict-e2e-runtime-only-default-syntax
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2143 +/- ##
==========================================
- Coverage 53.64% 53.63% -0.02%
==========================================
Files 224 224
Lines 7050 7050
Branches 3115 3115
==========================================
- Hits 3782 3781 -1
- Misses 3268 3269 +1 ☔ View full report in Codecov by Sentry. |
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Thu Mar 7 21:59:52 CET 2024 |
5 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #_
cargo-contractorpallet-contracts?Description
#[ink_e2e::test(backend(runtime_only))]and#[ink_e2e::test(backend(runtime_only(default)))]are valid syntax for setting the default drink! runtime emulator, this PR removes the latter syntax.#[ink_e2e::test(backend(runtime_only(runtime = ..)))])Checklist before requesting a review
CHANGELOG.md