Allow setting block time for off-chain testing#1721
Merged
cmichi merged 15 commits intouse-ink:masterfrom Mar 23, 2023
Merged
Conversation
CrommVardek
requested review from
HCastano,
SkymanOne,
ascjones and
cmichi
as code owners
1 task
cmichi
reviewed
Mar 20, 2023
cmichi
reviewed
Mar 20, 2023
cmichi
reviewed
Mar 20, 2023
cmichi
reviewed
Mar 20, 2023
cmichi
reviewed
Mar 20, 2023
Collaborator
cmichi
left a comment
cmichi
left a comment
There was a problem hiding this comment.
The PR is already pretty good, just some nits.
Could you also update the file CHANGELOG.md? There is an [Unreleased] section and you can add it under a ## Added heading there.
Co-authored-by: Michael Müller <[email protected]>
Co-authored-by: Michael Müller <[email protected]>
…//github.com/CrommVardek/ink into vardek-env-offchain-test-set-block-timestamp
cmichi
approved these changes
Mar 23, 2023
Collaborator
cmichi
left a comment
cmichi
left a comment
There was a problem hiding this comment.
Thank you, @CrommVardek !
Hope to see more PR's of you :-).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a
Engine::set_block_timestampfunction to solve issue #1713Added a test accordingly.