Rename CallBuilder::fire() method to invoke()#1604
Merged
Conversation
This keeps this more consistent since we're wrapping a few methods with `invoke` in the name anyways.
Codecov Report
@@ Coverage Diff @@
## master #1604 +/- ##
=======================================
Coverage 65.65% 65.65%
=======================================
Files 205 205
Lines 6286 6286
=======================================
Hits 4127 4127
Misses 2159 2159
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name of this has always been a bit inconsistent to me since we're calling
CallParams::invokeandink_env::invoke_contractunder the hood.While we're breaking stuff before the release I figured it would be a good time to make
the naming here more consistent.