Add E2E tests for Mapping functions#1492
Merged
Conversation
SkymanOne
requested review from
HCastano,
ascjones and
cmichi
as code owners
SkymanOne
changed the title
Mapping functions & fix E2E dry-run for Mappping::insert()Mapping functions
HCastano
reviewed
Nov 22, 2022
Contributor
HCastano
left a comment
HCastano
left a comment
There was a problem hiding this comment.
Nothing major. You're gonna need to do some fixes for the LangError changes
ascjones
reviewed
Nov 30, 2022
ascjones
approved these changes
Dec 2, 2022
Collaborator
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
LGTM, but I would wait until substrate-contracts-node is updated and the tests actually pass until merging. Otherwise our master CI will be red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1488 and closes #1472 by adding E2E tests for all
Mappingfunctions and correctly submitting the origin of the dry-run call during E2E test