Merged
Conversation
xgreenx
requested review from
HCastano,
Robbepop,
ascjones and
cmichi
as code owners
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑
These are the results when building the
Link to the run | Last update: Thu May 19 16:18:55 CEST 2022 |
Closed
Codecov Report
@@ Coverage Diff @@
## master #1267 +/- ##
===========================================
+ Coverage 62.32% 78.77% +16.45%
===========================================
Files 227 228 +1
Lines 8645 8679 +34
===========================================
+ Hits 5388 6837 +1449
+ Misses 3257 1842 -1415
Continue to review full report at Codecov.
|
cmichi
approved these changes
May 23, 2022
agryaznov
added a commit
that referenced
this pull request
Jun 22, 2022
* Fix links in release notes (#1277) * Revert "Optimise deny_payment. Use eerywhere semantic of deny. (#1267)" This reverts commit 1bfccc7. * Revert backward-incompatible piece of #1224: dependency on `[seal1] seal_set_storage` * Revert backward-incompatible piece of #1233: removal of eth_compatibility crate * bump crate versions + update RELEASES.md * Mapping::insert_return_size is back, having now both `seal1` and `seal0` seal_set_storage versions used * set_storage_silent -> set_storage_compat renaming * spell fix * Apply suggestions from code review Co-authored-by: Michael Müller <mich@elmueller.net> Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * Update crates/env/src/backend.rs Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * doc comments enhanced * `Mapping::insert()` to use backwards compatible seal fn * unreleased changes planned for 4.x removed from 3.x * Add more details to the release notes * fix catched issue with changed api function signature * fix storage trait dependent func * Apply new versions naming policy: step1. Old versions to keep their names. * Apply new versions naming policy: step2. Add `deprecated` attr and `# Compatibility` docs section * Apply suggestions from code review Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * fixes after next review round * more fixes after the review round * fmt * spellcheck config fix * Small wording fixes Co-authored-by: Michael Müller <mich@elmueller.net> Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> Co-authored-by: Hernando Castano <hernando@hcastano.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems we forgot to use optimization in cases if all constructors or methods don't accept payment.