Added keep_attr to #[ink::contract] and #[ink::trait_definition]#1145
Merged
cmichi merged 3 commits intoFeb 24, 2022
Merged
Conversation
…` to manage that attributes should be passed to call builder during codegen.
xgreenx
requested review from
HCastano,
Robbepop,
ascjones and
cmichi
as code owners
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑
These are the results when building the
Link to the run | Last update: Thu Feb 24 12:30:54 CET 2022 |
Codecov Report
@@ Coverage Diff @@
## master #1145 +/- ##
==========================================
+ Coverage 78.69% 78.73% +0.04%
==========================================
Files 252 254 +2
Lines 9395 9448 +53
==========================================
+ Hits 7393 7439 +46
- Misses 2002 2009 +7
Continue to review full report at Codecov.
|
cmichi
reviewed
Feb 24, 2022
| } | ||
|
|
||
| impl WhitelistedAttributes { | ||
| pub fn parse_arg_value(&mut self, arg: &MetaNameValue) -> Result<(), syn::Error> { |
Collaborator
There was a problem hiding this comment.
PR looks solid, could you add a comment to this pub function here please?
cmichi
reviewed
Feb 24, 2022
| } | ||
| } | ||
|
|
||
| pub fn filter_attr(&self, attrs: Vec<syn::Attribute>) -> Vec<syn::Attribute> { |
Collaborator
There was a problem hiding this comment.
And here a comment as well plz.
cmichi
approved these changes
Feb 24, 2022
Collaborator
cmichi
left a comment
cmichi
left a comment
There was a problem hiding this comment.
Thank you! Just two nitpicks from my side.
cmichi
reviewed
Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
keep_attrto#[ink::contract]and#[ink::trait_definition]to manage that attributes should be passed to call builder during codegen. All attributes are ignore by default except:cfg,cfg_attr,allow,warn,deny,forbid,deprecated,must_use,doc.More information in the conversation of #1130