Add workspace-enabled example contracts#44
Add workspace-enabled example contracts#44aon wants to merge 8 commits intouse-ink:mainfrom CoinFabrik:main
Conversation
|
use-ink/cargo-contract#1358 is merged now, please update this branch |
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
Could we use some dumb contracts instead like contract1, contract2, contract3, with e.g. just a single message and constructor. We only need to demonstrate that they compile as part of a workspace.
It just means that when the original example e.g. erc20 changes we don't need to remember to update the copy of it here too.
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
There was a problem hiding this comment.
Could we remove these and other tests? Reason is if the ink testing API changes then these will just be extra tests to update, they are just duplicates of existing ones anyway
There was a problem hiding this comment.
Understood. I'll recheck / rework on this. Probably re-create the PR. Thanks!
There was a problem hiding this comment.
(Also trying to adapt the merge to the actual HEAD of main version which changed the execution matrix)
There was a problem hiding this comment.
I'll be creating a new PR to replace this one from a new temporary and updated repo, fixing this things. Sorry for the inconvenience. I'll update this PR with a link to the new-one.
|
This can be closed in favor of PR:52 : #52 |
* feature: check contracts in workspace * fixes in CI * fixes in CI * fixes in CI: s/steps/step * fixes in CI: enable examples step * wip CI/CD: run contracts along regular ones, but with different step * wip CI/CD: log changed files also use the right variable to check for them * wip CI/CD: hopefuly preventing error on invalid character.. * wip CI/CD: changed approach to run both workspace contracts on same runner.. * wip CI/CD: whole workspace at once * wip CI/CD: specify workspace cargo * wip CI/CD: no test on workspace * wip CI/CD: removed debug info/vars * wip CI/CD: removed debug info/vars * updated the CI/CD to be ready when using/having cargo-contract v 4.0. * fix unnoticed error in contract * Update ci.yml removed redundant configuration Update ci.yml removed redundant configuration
4 participants
This PR creates a workspace where dependencies are defined and several smart-contracts as part of the same workspace, with inherited dependencies.
It was created following the recommendation made in use-ink/cargo-contract#1358. This should be merged after the mentioned PR is merged, given I had to force the branch version for running
cargo-contractin the CI.