Merged
Conversation
tgmichel
changed the title
Pending tag support for eth_getCodePending tag support
sorpaas
approved these changes
Dec 16, 2021
tgmichel
added a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Dec 17, 2021
* Add Pending tag support for eth_getCode * Add test * Add Pending tag support for additional methods * Update tests (cherry picked from commit 9937586) # Conflicts: # client/rpc/Cargo.toml
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
* Add Pending tag support for eth_getCode * Add test * Add Pending tag support for additional methods * Update tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
pendingtag in:eth_getBalanceeth_getCodeeth_getStorageAtIn addition to adding
pendingtag support to it,eth_calluses theBlockNumberparameter (previously not used).Note: if the pending contract is a future txn and some of the txns in the ready queue satisfies the requirements of the future one, this PR's approach won't do it because we only apply ready txns. @sorpaas I think current proposal is enough, but please let me know.