You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Regarding the TODO: I think passing hardcoded flags to cargo as it is done in this PR is fine. I wouldn't generate/mess with a .cargo/config that a user might want to edit manually.
What is not fine is hardcoding RUSTFLAGS. As far as I see it we just set the env variable to some hardcoded value. But that should be fixed in the mentioned issue. Not here.
I wouldn't generate/mess with a .cargo/config that a user might want to edit manually.
The idea would be that it would set the default hardcoded rustflags iff they are not specified by the user (like we do with the [profile.release] section. And also would ensure (since the env var overrides the value from .cargo/config) that a user supplied RUSTFLAGS is not ignored.
But that should be fixed in the mentioned issue. Not here.
Anyway I agree that this should be fixed separately with a little more thought.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build-stdfeature of cargo now allows to specify thepanic-immediate-abortfeature. See: https://github.com/rust-osdev/cargo-xbuild#alternative-the-build-std-feature-of-cargo.So we can use that (unstable) feature instead of depending on
xbuildProduces the same size wasm output as with
xbuilde.g. flipper: