Conversation
ascjones
approved these changes
Aug 23, 2022
athei
marked this pull request as ready for review
August 24, 2022 09:12
cmichi
added a commit
to paritytech/scripts
that referenced
this pull request
Aug 24, 2022
Follow-up to use-ink/cargo-contract#703.
cmichi
added a commit
to paritytech/scripts
that referenced
this pull request
Aug 24, 2022
Follow-up to use-ink/cargo-contract#703.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the brittle setup of compiling the dylints within our
build.rsfile. Instead, it patches the contracts manifest to run the dylint. The dylint itself will live inside the ink! repository and is downloaded from there. The build is quick and cached within thetargetdirectory as all other artifacts.Future Work
We don't want to pull the lint from master but rather from a tag that corresponds to the used ink! version. However, we don't wait for this because that is only possible once the next ink! version is released.